Test update#1
Open
marcdumais-work wants to merge 5 commits into
Open
Conversation
Small adaptations to root package.json, various tsconfig.json. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
It would be preferable to manage the version of traceviewer base and react libraries elsewhere. Lerna is stepping the various packages versions, when we do releases, using the package.json scripts entries, e.g. "yarn version:patch". The trick used is to have lerna only step the version of public packages (vscode-trace-extension only) and leave the others alone, including the traceviewer-* libraries. For this to work, it was necessary to mark the libraries as private - this change will have to be undone wherever they might get published to npm. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
With a correct tsconfig.json setup, it's possible to watch all the typescript workspaces' code using a single "tsc -b -w", executed at the repo root. It's also necessary to cover webpack where it is used. https://webpack.js.org/configuration/watch Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Branch generated from vscode-trace-extension (eclipse-cdt-cloud/vscode-trace-extension#339) with command: